feat(magicsock): add DERPTLSConfig for custom TLS configuration#105
Merged
deansheather merged 1 commit intocoder:mainfrom Mar 11, 2026
Merged
feat(magicsock): add DERPTLSConfig for custom TLS configuration#105deansheather merged 1 commit intocoder:mainfrom
deansheather merged 1 commit intocoder:mainfrom
Conversation
Add ability to configure a custom TLS config for DERP region clients. This enables scenarios like trusting internal CAs or presenting client certificates for DERP servers behind reverse proxies.
Member
|
The code looks good to me and seems to cover all bases. I wouldn't worry too much about adding tests here, we can add tests in the coder repo instead. Happy to approve and merge it once you're ready |
Member
|
The failing checks are expected, we don't maintain the CI in this fork other than getting tests to pass. |
deansheather
approved these changes
Mar 11, 2026
Member
|
Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ability to configure a custom TLS config for DERP region clients. This enables scenarios like trusting internal CAs or presenting client certificates. See coder/coder#22695 for related changes.
This code still needs more testing before I can mark it as ready for review, but I'm opening this PR in draft mode for anyone who may wish to review the changes earlier.
Disclaimer: I used Cursor, with supervision, to author this code.